(LedgerStore) LedgerColumn::multi_get() #26354
Conversation
|
The multi_get() API will be used to optimize get_slots_since() mentioned in #24878 |
|
Converting this PR back to a draft as we need a published version of rust-rocksdb release. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
yhchiang-sol
removed
the
stale
ledger/src/blockstore_db.rs
Outdated
| @@ -1289,6 +1307,41 @@ impl<C> LedgerColumn<C> | |||
| where | |||
| C: TypedColumn + ColumnName, | |||
| { | |||
| #[allow(clippy::needless_range_loop)] | |||
There was a problem hiding this comment.
We should be able to drop this now right?
So the batched version of multi_get() will try to group multiple get() requests into multiple batches where get() requests in the same batch will hit the same block. As a result, each batch of get() requests can be answered using one single disk read instead of multiple ones. |
mergify
bot
dismissed
steviez’s stale review
Pull request has been modified.
Problem
Blockstore operations such as get_slots_since() issues multiple rocksdb::get()
at once which is not optimal for performance.
Summary of Changes
This PR adds LedgerColumn::multi_get() based on rocksdb::batched_multi_get(),
the optimized version of multi_get() where get requests are processed in batch
to minimize read I/O.