Do not unwrap the oldest IP in QUIC connectiont table #26272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26272 +/- ##
========================================
Coverage 81.9% 81.9%
========================================
Files 631 631
Lines 174252 175173 +921
========================================
+ Hits 142728 143483 +755
- Misses 31524 31690 +166 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 28, 2022
(cherry picked from commit 31d870f)
mergify bot
added a commit
that referenced
this pull request
Jun 28, 2022
(cherry picked from commit 31d870f) Co-authored-by: Pankaj Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Calling
unwraponoldest_ipwhile it'sNoneis causing crash.Summary of Changes
If the table is empty, or has no valid entry, the value of
oldest_ipwill beNone.This is a defensive check to use
oldest_iponly when it is notNone.Fixes #26263