Enable wire compression in Solana CLI and Rust client #26236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveluscher
commented
Jun 27, 2022
steveluscher
added
enhancement
|
This PR is meant to be accompanied by #26262 so that RPC providers can measure if there's a drop in egress with the new version. |
mvines
approved these changes
Jun 27, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
(cherry picked from commit 9765034) # Conflicts: # Cargo.lock # cli/Cargo.toml # client/Cargo.toml # core/Cargo.toml # download-utils/Cargo.toml # install/Cargo.toml # metrics/Cargo.toml # notifier/Cargo.toml # rpc-test/Cargo.toml
steveluscher
added a commit
that referenced
this pull request
Jun 27, 2022
steveluscher
added a commit
that referenced
this pull request
Jun 28, 2022
steveluscher
added a commit
that referenced
this pull request
Jun 28, 2022
mergify bot
added a commit
that referenced
this pull request
Jun 28, 2022
Co-authored-by: Steven Luscher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Are you feeling SQUEEZED? Has life got you in a VICE? Is the PRESSURE getting to you? Well SQUEEZE BACK!
JSON is a terrible wire format, full of redundant markup and waste. The easiest mitigation for this is to employ a wire compression algorithm, like gzip. Savings can be as much as 80%.
Wire compression, however, works better when you turn it on.
Summary of Changes
reqwestdependency fromcore, where it is – in fact – not used.Test plan
This PR doesn't need to be tested, per se, because the implementation of the HTTP header-crafting and response decompression is already tested as part of the Rust
reqwestcrate.Here's a run of
cargo run block 125791054with a proxy on the wire. You can see the newaccept-encodingheader being sent in the request, and Triton's RPC proxy responding with a gzipped response body. 80% reduction in bytes over the wire too!Thanks!
Thank you to @linuskendall for bringing this one to my attention!