Fix incorrect total connection table size in the quic server when removing multiple connections with the same IP:Port #26073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oving multiple connections with the same IP:Port
jstarry
reviewed
Jun 20, 2022
jstarry
reviewed
Jun 20, 2022
…le connections associated with an IP:Port pair
Added. |
mergify bot
added a commit
that referenced
this pull request
Jun 27, 2022
…oving multiple connections with the same IP:Port (#26073) (#26270) * Fix incorrect total connection table size in the quic server when removing multiple connections with the same IP:Port (cherry picked from commit 84a1aae) Co-authored-by: ryleung-solana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are currently always assuming we remove 1 connection from the quic server connection table when we remove the connections associated with an IP:Port pair. However, there may actually be multiple connections associated with an IP:Port pair. In that case, the total connection table size becomes incorrect due to this incorrect assumption.
Summary of Changes
Calculate the number of connections actually removed from the connection table and subtract this value from the total connection table size.
Fixes #