add get_account to BenchTpsClient #26068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
88
to
97
| let account = SyncClient::get_account(self, pubkey).map_err(|err| err.into()); | ||
| if let Ok(account) = account { | ||
| if account.is_none() { | ||
| return Err(BenchTpsError::Custom("Account was not found".to_string())); | ||
| } | ||
| Ok(account.unwrap()) | ||
| } else { | ||
| Err(account.err().unwrap()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| let account = SyncClient::get_account(self, pubkey).map_err(|err| err.into()); | |
| if let Ok(account) = account { | |
| if account.is_none() { | |
| return Err(BenchTpsError::Custom("Account was not found".to_string())); | |
| } | |
| Ok(account.unwrap()) | |
| } else { | |
| Err(account.err().unwrap()) | |
| } | |
| } | |
| SyncClient::get_account(self, pubkey) | |
| .map_err(|err| err.into()) | |
| .and_then(|account| account.ok_or(BenchTpsError::Custom("Account was not found".to_string()))) |
Simpler and more rust-y. (Suggestion probably needs formatting)
There was a problem hiding this comment.
Also, could we emulate the logic in RpcClient::get_account so we don't have to have this one-off custom error?
There was a problem hiding this comment.
and_then looks cool, thanks!
KirillLykov
force-pushed
the
addGetAccount
branch
from
937d6e1 to
dbc2661
Compare
CriesofCarrots
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no method
get_accountforBenchTpsClientwhich is needed for follow up PRs adding durable nonce transactions.Summary of Changes
get_accountmethod