This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Reduce 2 iterators to one #25973
Merged
Reduce 2 iterators to one #25973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
approved these changes
Jun 14, 2022
1 task
CriesofCarrots
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
(cherry picked from commit 8a3d48b)
mergify bot
added a commit
that referenced
this pull request
Jun 15, 2022
(cherry picked from commit 8a3d48b) Co-authored-by: Tyera Eulberg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Replay's blockstore_processor iterates through transaction batches twice to pull out lock results and then transactions. Could be done in one iteration instead.
Summary of Changes
Combine iterators into one (prep for adding another array in #25688)