Account interface that works with overlays. #2595
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2595 +/- ##
========================================
Coverage ? 78.1%
========================================
Files ? 112
Lines ? 18250
Branches ? 0
========================================
Hits ? 14255
Misses ? 3995
Partials ? 0 |
Codecov Report
@@ Coverage Diff @@
## master #2595 +/- ##
========================================
Coverage ? 77.7%
========================================
Files ? 112
Lines ? 18156
Branches ? 0
========================================
Hits ? 14108
Misses ? 4048
Partials ? 0 |
aeyakovenko
added
the
automerge
solana-grimes
removed
the
automerge
|
💔 Unable to automerge due to CI failure |
aeyakovenko
added
the
automerge
|
💔 Unable to automerge due to CI failure |
solana-grimes
removed
the
automerge
| if account.tokens == 0 { | ||
| self.accounts.remove(pubkey); | ||
| if purge { |
There was a problem hiding this comment.
purge is hurting my brain... is that only set on collapse of a fork?
There was a problem hiding this comment.
@rob-solana, yea when merging into root it’s set to true. I could probably hide it better.
There was a problem hiding this comment.
you could accept the same &[U] argument as load() does and deduce purge by checkpoints.len()?
| @@ -178,7 +179,7 @@ impl Bank { | |||
| loader: solana_native_loader::id(), | |||
| }; | |||
| self.accounts | |||
| .store_slow(&system_program::id(), &system_program_account); | |||
| .store_slow(true, &system_program::id(), &system_program_account); | |||
There was a problem hiding this comment.
if you store(tokens=0) with purge=true onto a fork with a parent, it exposes the parent's state, right?
* Move last_id and signature dup handling out of Accounts. * Accounts that handle overlays.
aeyakovenko
force-pushed
the
checkpoints_2
branch
from
a019731 to
2239b8e
Compare
aeyakovenko
added
the
automerge
|
part of #2289 |
Problem
Account interface handles last_id and signature dup verification. It should only handle accounts, and it needs to work with overlays for checkpointing and forking.
Summary of Changes
Fixes #