Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot_utils.rs: remove unnecessary sort #25893

Merged
merged 1 commit into from
Jun 13, 2022
Merged

snapshot_utils.rs: remove unnecessary sort #25893

merged 1 commit into from
Jun 13, 2022

Conversation

apfitzge
Copy link
Contributor

Problem

We check if the length is greater than 1, and error if it is. The sort is unnecessary.

Summary of Changes

Removed the sort

Fixes #

@apfitzge apfitzge marked this pull request as ready for review June 10, 2022 14:57
@apfitzge apfitzge requested a review from mvines June 10, 2022 21:06
steviez
steviez approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@apfitzge apfitzge merged commit 3e1fd4d into solana-labs:master Jun 13, 2022
@apfitzge apfitzge deleted the clean_up/remove_unnecessary_sort branch June 13, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviez steviez steviez approved these changes

@mvines mvines Awaiting requested review from mvines

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apfitzge @steviez