Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isBlockhashValid method to web3.js #25888
Add isBlockhashValid method to web3.js #25888
Changes from 10 commits
b6332f9
1c08c37
6ef0a2a
ca50893
c440a9e
b04ff28
3333af4
88387b9
762f277
87d2bb6
1ec6a95
7040f0e
07e97a0
88f1852
b2d82bf
ff51656
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, you want to take an
Omit
approach rather than aPick
approach.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have special handling for when the min context slot isn't met. It can be detected from its error code:
We could retry a few times (configurable in
IsBlockhashValidConfig
). What do you think? I wouldn't mind this change coming later in a separate PR too. So maybe we just ensure that the thrown error object includes the error code as an integerThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat. Two questions come to mind:
res
and retry a configurable amount of times before bailing?IsBlockhashValid
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I include this in the current PR? @jstarry @steveluscher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you made this PR, we introduced
SolanaJSONRPCError
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
mockRpcResponse
helper actually skips when you're in live mode, so that you only have to write the tests once.