Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RpcSimulateTransactionConfig for rpc_client::get_stake_minimum_delegation() #25426

Closed

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented May 20, 2022

Problem

When calling rpc_client::get_stake_minimum_delegation() from CLI, the simulate_transaction() fails.

Summary of Changes

Need to customize the RPC Simulate Transaction Config to:

  • have a payer
  • skip sig verify
  • replace the blockhash

Further fix for #24690

@brooksprumo brooksprumo force-pushed the rpc-client/skip-sigverify branch from 26f9655 to 6e4bde1 Compare May 20, 2022 21:46
@brooksprumo brooksprumo linked an issue May 20, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #25426 (6e4bde1) into master (f9f6b94) will increase coverage by 0.0%.
The diff coverage is 73.8%.

@@            Coverage Diff            @@
##           master   #25426     +/-   ##
=========================================
  Coverage    82.0%    82.0%             
=========================================
  Files         655      619     -36     
  Lines      171822   169966   -1856     
  Branches      335        0    -335     
=========================================
- Hits       140972   139461   -1511     
+ Misses      30734    30505    -229     
+ Partials      116        0    -116     

@brooksprumo brooksprumo marked this pull request as ready for review May 21, 2022 01:07
@brooksprumo
Copy link
Contributor Author

@CriesofCarrots I know we talked about adding a full-fledged RPC endpoint to query the minimum stake delegation; is this change still useful until then though?

@CriesofCarrots
Copy link
Contributor

@CriesofCarrots I know we talked about adding a full-fledged RPC endpoint to query the minimum stake delegation; is this change still useful until then though?

Since we'll be making an rpc request instead of building a transaction, I don't think so. In fact, we might want to remove the client method until it works...?

@stale
Copy link

stale bot commented Jun 12, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Jun 12, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to get stake minimum delegation from RPC
2 participants