Add get_confirmed_transactions to storage-bigtable
#25404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
stale
bot
removed
stale
|
I changed code so now transactions will be returned in the order in which they were requested |
CriesofCarrots
approved these changes
Jul 5, 2022
| .transactions | ||
| .get(index as usize) | ||
| .and_then(|tx_with_meta| { | ||
| if tx_with_meta.transaction_signature().to_string() != *signature { |
There was a problem hiding this comment.
Nit: i's a pity to have to do this additional stringification, when we already have the requested Signatures. I'm not going to hold this PR up any further on this, but do you have any clever ideas?
CriesofCarrots
added
the
automerge
fanatid
added a commit
to fanatid/solana
that referenced
this pull request
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's possible to get few blocks with
get_confirmed_blocks_with_databut there is no method for get few transactions.Summary of Changes
Add
LedgerStorage::get_confirmed_transactionstosolana-storage-bigtable.