Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't drop transactions which use a request heap size ix #25315

Merged
merged 1 commit into from
May 18, 2022

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented May 18, 2022

Problem

The transaction prioritization added in #25178 unintentionally caused banking stage to drop all incoming transactions which use request heap instructions.

Summary of Changes

  • Accept transactions which use request heap instructions in banking stage

Fixes #

@jstarry jstarry added automerge Merge this Pull Request automatically once CI passes v1.10 labels May 18, 2022
@jstarry jstarry requested a review from tao-stones May 18, 2022 07:17
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label May 18, 2022
@mergify
Copy link
Contributor

mergify bot commented May 18, 2022

automerge label removed due to a CI failure

@jstarry jstarry merged commit 5548baf into solana-labs:master May 18, 2022
@jstarry jstarry deleted the fix/request-heap-ixs branch May 18, 2022 09:47
mergify bot pushed a commit that referenced this pull request May 18, 2022
mergify bot added a commit that referenced this pull request May 18, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant