Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: Add minContextSlot param to ensure consistent responses (backport #25161) #25313

Merged
merged 2 commits into from
May 18, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 18, 2022

This is an automatic backport of pull request #25161 done by Mergify.
Cherry-pick of 4690956 has failed:

On branch mergify/bp/v1.10/pr-25161
Your branch is up to date with 'origin/v1.10'.

You are currently cherry-picking commit 469095684.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   client-test/tests/client.rs
	modified:   client/src/nonblocking/rpc_client.rs
	modified:   client/src/rpc_client.rs
	modified:   client/src/rpc_config.rs
	modified:   client/src/rpc_custom_error.rs
	modified:   rpc-test/tests/rpc.rs
	modified:   rpc/src/rpc.rs
	modified:   rpc/src/rpc_pubsub.rs
	modified:   rpc/src/rpc_service.rs
	modified:   rpc/src/rpc_subscriptions.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/src/developing/clients/jsonrpc-api.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* RPC: Add minContextSlot param to ensure consistent responses

* revert changes to deprecated endpoints

* update docs

(cherry picked from commit 4690956)

# Conflicts:
#	docs/src/developing/clients/jsonrpc-api.md
@mergify mergify bot added the conflicts label May 18, 2022
@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels May 18, 2022
@mergify
Copy link
Contributor Author

mergify bot commented May 18, 2022

automerge label removed due to a CI failure

@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label May 18, 2022
@mergify
Copy link
Contributor Author

mergify bot commented May 18, 2022

automerge label removed due to a CI failure

@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels May 18, 2022
@mergify
Copy link
Contributor Author

mergify bot commented May 18, 2022

automerge label removed due to a CI failure

@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels May 18, 2022
@jstarry jstarry merged commit 3b51dfb into v1.10 May 18, 2022
@mergify mergify bot deleted the mergify/bp/v1.10/pr-25161 branch May 18, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant