-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: thread new blockheight expiry strategy through sendAndConfirmTransaction
#25227
Merged
steveluscher
merged 7 commits into
solana-labs:master
from
steveluscher:thread-new-blockheight-expiry-strategy-through-sact
May 15, 2022
Merged
feat: thread new blockheight expiry strategy through sendAndConfirmTransaction
#25227
steveluscher
merged 7 commits into
solana-labs:master
from
steveluscher:thread-new-blockheight-expiry-strategy-through-sact
May 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveluscher
changed the title
Thread new blockheight expiry strategy through sact
feat: thread new blockheight expiry strategy through May 15, 2022
sendAndConfirmTransaction
Codecov Report
@@ Coverage Diff @@
## master #25227 +/- ##
===========================================
- Coverage 82.0% 75.0% -7.1%
===========================================
Files 598 38 -560
Lines 165882 2302 -163580
Branches 0 335 +335
===========================================
- Hits 136125 1727 -134398
+ Misses 29757 459 -29298
- Partials 0 116 +116 |
steveluscher
deleted the
thread-new-blockheight-expiry-strategy-through-sact
branch
May 15, 2022 04:55
This comment was marked as spam.
This comment was marked as spam.
This was referenced Jun 6, 2022
This was referenced Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
sendTransaction
right now only fetches a recent blockhash using the deprecatedgetRecentBlockhash()
method. Notably this is missing thelastValidBlockHeight
property that's needed to use the blockheight-based transaction confirmation strategy.Summary of Changes
Teach the ‘recent blockhash’ cache to fetch using
getLatestBlockhash
and thread thelastValidBlockHeight
down toconfirmTransaction
through its membership onTransaction
.Fixes #23949.