Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Disallow deployment of deprecated _sol_alloc_free syscall (#2… #25170

Merged
merged 1 commit into from
May 12, 2022
Merged

Revert "Disallow deployment of deprecated _sol_alloc_free syscall (#2… #25170

merged 1 commit into from
May 12, 2022

Conversation

jackcmay
Copy link
Contributor

…4986)"

This reverts commit 8f1d4c1.

Problem

Hash mismatch, pulling out for investigation

Summary of Changes

Fixes #

@jackcmay jackcmay added the automerge Merge this Pull Request automatically once CI passes label May 12, 2022
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label May 12, 2022
@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

automerge label removed due to a CI failure

@jeffwashington
Copy link
Contributor

rebased on master and pushed to try to get around client_targets build errors

@jeffwashington
Copy link
Contributor

reverted another change that broke the apple builds. rebased this one and pushed again

@jeffwashington
Copy link
Contributor

@jackcmay
to reproduce failure:
am6:

cd src/solana/ledger-tool
cargo run --release --bin solana-ledger-tool -- --ledger /mnt/nvme1n1/ledger_25170 --snapshot-archive-path /home/sol/ledger-snapshots_25170 verify --allow-dead-slots --accounts-db-skip-shrink --halt-at-slot 132302179

success:

calculate_accounts_hash_without_index: slot (exclusive): 132302180 (oK63QW7f8y1nkDK3bDuF7cVc58q2gY37jUpDazDKgqG, 1487718633602880595)
bank frozen: 132302179 hash: VknY2E6NUaQmGmJUetjkdNhJgk56CZPTx4fqP9J7Ldq accounts_delta: Ct8xUf3EeBHy2d66PyKiTWPtbK4JcH8FukTbX9mZaCVH signature_count: 3492 last_blockhash: FyqfxwXvAh8DRi7ZFL13eKLnWHNbXianvhs3ABRAcXRi capitalization: 1487718633602880595

failure:

calculate_accounts_hash_without_index: slot (exclusive): 132302180 (BqXKEZtqVgp3yAiE2eFTEc4KvcREwNAPNWJFLfMtGDPN, 1487718633602880595)
bank frozen: 132302179 hash: HgnyRW6KmPwY5eMmEs7s85xUR6K21uHCSrTtLgDiv3Fc accounts_delta: 3HFGV4L8wj6Ds2CKjE3sHaZ5MgfA9TtKVDyE9Rxs9CRv signature_count: 3492 last_blockhash: FyqfxwXvAh8DRi7ZFL13eKLnWHNbXianvhs3ABRAcXRi capitalization: 1487718633602880595

@jackcmay jackcmay added the automerge Merge this Pull Request automatically once CI passes label May 12, 2022
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label May 12, 2022
@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

automerge label removed due to a CI failure

@jeffwashington jeffwashington merged commit 8902a66 into solana-labs:master May 12, 2022
@jackcmay jackcmay deleted the revert-8f1d4c1665 branch May 23, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackcmay @jeffwashington