Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test_bank_cloned_stake_delegations() aware of stake minimum delegation #24753

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Make test_bank_cloned_stake_delegations() aware of stake minimum delegation #24753

merged 2 commits into from
Apr 28, 2022

Conversation

brooksprumo
Copy link
Contributor

Problem

The bank test test_bank_cloned_stake_delegations() fails once the stake minimum delegation is raised. See #24603 for more context.

Summary of Changes

  • Update bank test_bank_cloned_stake_delegations() to be aware of stake minimum delegation

@brooksprumo brooksprumo force-pushed the fix-tests/bank_cloned_stake_delegations branch from 9d547ba to b30b67a Compare April 27, 2022 21:23
@brooksprumo brooksprumo marked this pull request as ready for review April 27, 2022 23:21
@brooksprumo brooksprumo requested a review from joncinque April 27, 2022 23:21
joncinque
joncinque reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go otherwise, just the one question about rent.

runtime/src/bank.rs Show resolved Hide resolved
@brooksprumo brooksprumo requested a review from joncinque April 28, 2022 01:11
joncinque
joncinque approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding the non-free rent!

@brooksprumo brooksprumo merged commit 7b6880f into solana-labs:master Apr 28, 2022
@brooksprumo brooksprumo deleted the fix-tests/bank_cloned_stake_delegations branch April 28, 2022 14:40
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
@brooksprumo @jeffwashington
Make test_bank_cloned_stake_delegations() aware of stake minimum dele…
6051670 
…gation (solana-labs#24753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brooksprumo @joncinque