Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MINIMUM_STAKE_DELEGATION #24329

Merged

Conversation

brooksprumo
Copy link
Contributor

Problem

Now that solana_program::stake::tools::get_minimum_delegation() has been added, the MINIMUM_STAKE_DELEGATION constant should not be used.

Summary of Changes

Deprecate the MINIMUM_STAKE_DELEGATION constant.

@brooksprumo brooksprumo marked this pull request as ready for review April 14, 2022 00:31
@brooksprumo brooksprumo requested a review from jstarry April 14, 2022 00:31
jstarry
jstarry previously approved these changes Apr 14, 2022
programs/stake/src/lib.rs Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #24329 (2dca826) into master (b9caa8c) will increase coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 2dca826 differs from pull request most recent head 3e22ae1. Consider uploading reports for the commit 3e22ae1 to get more accurate results

@@           Coverage Diff           @@
##           master   #24329   +/-   ##
=======================================
  Coverage    82.1%    82.1%           
=======================================
  Files         582      582           
  Lines      162041   162041           
=======================================
+ Hits       133132   133182   +50     
+ Misses      28909    28859   -50     

@brooksprumo brooksprumo force-pushed the minimum-stake/deprecate-constant branch from 2dca826 to 3e22ae1 Compare April 14, 2022 14:13
@mergify mergify bot dismissed jstarry’s stale review April 14, 2022 14:13

Pull request has been modified.

@brooksprumo
Copy link
Contributor Author

Had to force-push to resolve a merge conflict.

@brooksprumo brooksprumo merged commit 2456a7b into solana-labs:master Apr 14, 2022
@brooksprumo brooksprumo deleted the minimum-stake/deprecate-constant branch April 14, 2022 16:59
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants