This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
dashmap -> rwlock<hashmap> for rewrites #24327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24327 +/- ##
===========================================
+ Coverage 70.0% 82.1% +12.0%
===========================================
Files 36 582 +546
Lines 2237 162043 +159806
Branches 315 0 -315
===========================================
+ Hits 1568 133109 +131541
- Misses 559 28934 +28375
+ Partials 110 0 -110 |
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is written once in a non-contentious part of code, but read many times independent of the write.
Makes more sense as rwlock hashmap.
Summary of Changes
Fixes #