bloom for forking #2431
Merged
bloom for forking #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
Jan 15, 2019
|
So the reason that was in a separate module is so that we have the option to move it to the SDK and have Hash and Pubkey implement the traits alongside their definitions. The implementation has to be colocated with either the trait definition or the struct definition. Seems cleaner to attach to the struct definition, but I don't feel too strongly about it. |
Codecov Report
@@ Coverage Diff @@
## master #2431 +/- ##
========================================
+ Coverage 76.7% 76.7% +<.1%
========================================
Files 111 110 -1
Lines 17438 17460 +22
========================================
+ Hits 13377 13395 +18
- Misses 4061 4065 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tiniest part of #2289