Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Fix GenKeys #243

Merged
merged 2 commits into from
May 23, 2018
Merged

Fix GenKeys #243

merged 2 commits into from
May 23, 2018

Conversation

garious
Copy link
Contributor

@garious garious commented May 23, 2018

I think this line was overrunning the seed buffer:

let rng: ChaChaRng = SeedableRng::from_seed(unsafe { mem::transmute(seed) });

garious added 2 commits May 23, 2018 13:55
@garious
GenKeys cleanup
3cbb7a2
@garious
Fix nondeterministic key generation
e930bf8 
Our one and only unsafe operation was ...unsafe.
@garious garious requested a review from sakridge May 23, 2018 19:59
@garious garious merged commit 8447783 into solana-labs:master May 23, 2018
AshwinSekar pushed a commit to AshwinSekar/solana that referenced this pull request Mar 19, 2024
@mergify @yihau
v1.18: [anza migration]: add 'agave=info' to default log level (backp…
e9bc805 
…ort of solana-labs#223) (solana-labs#243)

[anza migration]: add 'agave=info' to default log level (solana-labs#223)

(cherry picked from commit 51dc7e6)

Co-authored-by: Yihau Chen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sakridge sakridge Awaiting requested review from sakridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@garious