featurize bpf function hash collision fix #24262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackcmay
added
the
feature-gate
Codecov Report
@@ Coverage Diff @@
## master #24262 +/- ##
=========================================
+ Coverage 81.8% 82.0% +0.2%
=========================================
Files 581 581
Lines 158312 161383 +3071
=========================================
+ Hits 129518 132367 +2849
- Misses 28794 29016 +222 |
jackcmay
force-pushed
the
featurize-hash-collision-fix
branch
from
b0bd538 to
52b048f
Compare
|
@merify-io rebase |
jackcmay
force-pushed
the
featurize-hash-collision-fix
branch
from
52b048f to
06d1871
Compare
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a potential for conflicting hashes between syscalls and BPF functions could result in unexpected behavior
Summary of Changes
Error if detected
Fixes #
Feature gate issue #24261