-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convenience function to make it easier for programs to retrieve the result of GetMinimumDelegation #24175
Merged
brooksprumo
merged 7 commits into
solana-labs:master
from
brooksprumo:minimum-stake/helper-fn
Apr 13, 2022
Merged
Add convenience function to make it easier for programs to retrieve the result of GetMinimumDelegation #24175
brooksprumo
merged 7 commits into
solana-labs:master
from
brooksprumo:minimum-stake/helper-fn
Apr 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
added
work in progress
This isn't quite right yet
noCI
Suppress CI on this Pull Request
labels
Apr 7, 2022
jstarry
reviewed
Apr 8, 2022
brooksprumo
force-pushed
the
minimum-stake/helper-fn
branch
3 times, most recently
from
April 11, 2022 21:27
53a6772
to
9e36279
Compare
brooksprumo
added
CI
Pull Request is ready to enter CI
and removed
work in progress
This isn't quite right yet
noCI
Suppress CI on this Pull Request
labels
Apr 11, 2022
brooksprumo
changed the title
wip: add minimum stake/helper fn
Add convenience function to make it easier for programs to retrieve the result of GetMinimumDelegation
Apr 11, 2022
brooksprumo
commented
Apr 11, 2022
5 tasks
brooksprumo
force-pushed
the
minimum-stake/helper-fn
branch
from
April 11, 2022 21:45
9e36279
to
88c2968
Compare
jstarry
reviewed
Apr 12, 2022
jstarry
reviewed
Apr 12, 2022
jstarry
reviewed
Apr 12, 2022
Codecov Report
@@ Coverage Diff @@
## master #24175 +/- ##
=========================================
+ Coverage 81.8% 81.9% +0.1%
=========================================
Files 581 582 +1
Lines 158312 161467 +3155
=========================================
+ Hits 129518 132394 +2876
- Misses 28794 29073 +279 |
jstarry
reviewed
Apr 13, 2022
t-nelson
reviewed
Apr 13, 2022
Co-authored-by: Justin Starry <[email protected]>
5 tasks
jstarry
approved these changes
Apr 13, 2022
brooksprumo
added a commit
to brooksprumo/solana
that referenced
this pull request
May 2, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Getting the value after calling stake instruction
GetMinimumDelegation
is somewhat cumbersome and potentially prone to error.Summary of Changes
Add a helper function to get the minimum delegation value.