-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature gate prompt and backport label automation #24023
Add feature gate prompt and backport label automation #24023
Conversation
I wonder if we can automate adding the |
Ah great call, added that as well. I think it's still useful to automate copying the label for backports because some feature gate related changes don't change that file. |
I think we'd only want to do it on |
Oh true, well then I think the pull request template prompt should be sufficient for devs to develop the habit of annotating PRs with the label if they add feature gate changes. I'll revert the automation for adding the label |
lmao. half of folks don't even fill it out until after creating the PR. I get so many empty template emails. I mean, I'm fine with the attempt. I'm just not optimistic it's going to be adhered to in any reliable manner |
2d44ca2
to
5f18281
Compare
Yeah it's a best effort thing to improve visibility. I'll at least find it useful for searching for my own feature-gate PR's. Good to go then? |
yeah sure. I barely know how mergify works |
Problem
Lack of feature gate process and visibility
Summary of Changes
sdk/src/feature_set.rs
fileFixes #