Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gate prompt and backport label automation #24023

Merged

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Mar 31, 2022

Problem

Lack of feature gate process and visibility

Summary of Changes

  • Adds an optional prompt for "Feature Gate Details" when creating pull requests which requests devs to describe feature gate changes and conditions as well as add the new "feature-gate" label to their PR for visibility
  • Adds automation for copying "feature-gate" labels to backport PR's
  • Adds automation for applying the "feature-gate" label to PR's that change the sdk/src/feature_set.rs file

Fixes #

@jstarry jstarry requested review from mvines and t-nelson March 31, 2022 03:58
@t-nelson
Copy link
Contributor

I wonder if we can automate adding the feature-gate label by scanning changes to sdk/src/feature_set.rs?

@jstarry
Copy link
Member Author

jstarry commented Apr 1, 2022

I wonder if we can automate adding the feature-gate label by scanning changes to sdk/src/feature_set.rs?

Ah great call, added that as well. I think it's still useful to automate copying the label for backports because some feature gate related changes don't change that file.

@t-nelson
Copy link
Contributor

t-nelson commented Apr 1, 2022

I think we'd only want to do it on solana_sdk::declare_id additions though, right? otherwise we tag removals other other irrelevant updates too. mergify may not be the tool for this job

@jstarry
Copy link
Member Author

jstarry commented Apr 1, 2022

Oh true, well then I think the pull request template prompt should be sufficient for devs to develop the habit of annotating PRs with the label if they add feature gate changes. I'll revert the automation for adding the label

@t-nelson
Copy link
Contributor

t-nelson commented Apr 1, 2022

lmao. half of folks don't even fill it out until after creating the PR. I get so many empty template emails.

I mean, I'm fine with the attempt. I'm just not optimistic it's going to be adhered to in any reliable manner

@jstarry jstarry force-pushed the meta/add-feature-details-prompt branch from 2d44ca2 to 5f18281 Compare April 1, 2022 05:40
@jstarry
Copy link
Member Author

jstarry commented Apr 1, 2022

Yeah it's a best effort thing to improve visibility. I'll at least find it useful for searching for my own feature-gate PR's. Good to go then?

@t-nelson
Copy link
Contributor

t-nelson commented Apr 1, 2022

yeah sure. I barely know how mergify works

@jstarry jstarry merged commit 0188e26 into solana-labs:master Apr 1, 2022
ngundotra pushed a commit to ngundotra/solana that referenced this pull request Apr 2, 2022
ngundotra pushed a commit to ngundotra/solana that referenced this pull request Apr 2, 2022
ngundotra pushed a commit to ngundotra/solana that referenced this pull request Apr 2, 2022
@jstarry jstarry deleted the meta/add-feature-details-prompt branch April 14, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants