Use VoteAccountsHashMap type alias in all applicable spots #23904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@behzadnouri - This would definitely create a merge conflict for your immutable HashMap change. That being said, this would lower the noise in that diff a little (always good for more meaningful changes). And, if we end up discarding that change, this cleanup with be good to have anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I was poking around a little from #23692 (and issue it aims to address) and found it inconvenient to find all instances
HashMap<Pubkey, (/*stake:*/ u64, VoteAccount)>, given that some usedVoteAccountsHashMaptype alias, as well as there being a mix of including/excluding the/*stake:*/comment.Summary of Changes
Use
VoteAccountsHashMaptype alias everywhere and appease clippy - no functional changes