don't start extra threads for shrink/clean/hash #23858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
approved these changes
Mar 23, 2022
| /// startup (not steady state execution) | ||
| /// but also requesting additional threads to be running to flush the acct idx to disk asap | ||
| /// The idea is that the best perf to ssds will be with multiple threads, | ||
| /// but during steady state, we can't allocate as many threads because we'd starve the rest of the system. |
| pub fn set_startup(&self, value: bool) { | ||
| if value { | ||
| pub fn set_startup(&self, startup: Startup) { | ||
| let value = !matches!(startup, Startup::Normal); |
There was a problem hiding this comment.
maybe, make it an associated method on Startup enum for checking if it is normal start?
| if value { | ||
| pub fn set_startup(&self, startup: Startup) { | ||
| let value = !matches!(startup, Startup::Normal); | ||
| if matches!(startup, Startup::StartupWithExtraThreads) { |
There was a problem hiding this comment.
same as above. add a method on enum to check if it is with extrathreads?
giogam
pushed a commit
to giogam/solana
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Fixes #