Compare accounts_data_len in Bank PartialEq #23717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
brooksprumo
changed the title
brooksprumo
added
v1.10
blocked
|
Closing this until we need it again. Currently cannot enable the feature this PR was originally in support of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bank::eq()does not compare theBank::accounts_data_lenfield for equality. I assume we would want to check this to ensure the Banks are equal, yes?Summary of Changes
If both banks have enabled the cap_accounts_data_len feature, then
Bank::eq()will also compareBank::accounts_data_len.Part of #21604
Blocked by #23744