Make solana-address-lookup-table-program crate bpf compatible #23700
Conversation
There was a problem hiding this comment.
looks good + one nit. This might actually be a better way forward than the current design of "just stick everything in sdk / program".
Instead of using target_arch everywhere, as another option, we could use the no-entrypoint feature as a convention even for builtin programs, so that pulling in program-runtime and sdk is dependent on the feature instead of the bpf arch. What do you think?
Approving either way since the changes are good.
| #[cfg(not(target_arch = "bpf"))] | ||
| impl From<AddressLookupError> for TransactionError { | ||
| fn from(err: AddressLookupError) -> Self { | ||
| match err { | ||
| AddressLookupError::LookupTableAccountNotFound => Self::AddressLookupTableNotFound, | ||
| AddressLookupError::InvalidAccountOwner => Self::InvalidAddressLookupTableOwner, | ||
| AddressLookupError::InvalidAccountData => Self::InvalidAddressLookupTableData, | ||
| AddressLookupError::InvalidLookupIndex => Self::InvalidAddressLookupTableIndex, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: what do you think about keeping just this part in solana-sdk? Then you can avoid at least one target_arch cfg
There was a problem hiding this comment.
Then solana-sdk would need to depend on solana-address-lookup-table-program and there would be a circular dependency
| # list of crates which must be buildable for bpf programs | ||
| solana-address-lookup-table-program = { path = "../../../../programs/address-lookup-table", version = "=1.10.3" } |
I did consider that and then considered renaming to |
Makes sense, thanks for the explanation |
Codecov Report
@@ Coverage Diff @@
## master #23700 +/- ##
=========================================
- Coverage 81.8% 81.7% -0.1%
=========================================
Files 581 582 +1
Lines 158312 158266 -46
=========================================
- Hits 129518 129364 -154
- Misses 28794 28902 +108 |
Problem
The
solana-address-lookup-table-programcrate cannot be used as a dependency when building bpf programsSummary of Changes
cfgattributes to disable BPF incompatible dependencies and instruction processingAddressLookupErrorto thesolana-address-lookup-table-programto make state types usable without asolana-sdkdependency.solana-address-lookup-table-programas a dependency for thedep-cratetest program to ensure that compatibility is preserved in the futureFixes #23410