Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make payer and system program optional when extending lookup tables #23678

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Mar 15, 2022

Problem

When a lookup table is pre-funded for new addresses, it's not necessary to pass a payer account and the system program when extending the lookup table with new address entries.

Summary of Changes

  • Update instruction API to extend lookup tables without a payer key
  • Skip payer account validation for ExtendLookupTable if no payment is required

Fixes #23411

@jstarry jstarry requested a review from joncinque March 15, 2022 16:10
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #23678 (eef847a) into master (8c4f010) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

@@            Coverage Diff            @@
##           master   #23678     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         580      580             
  Lines      158245   158248      +3     
=========================================
- Hits       129399   129381     -18     
- Misses      28846    28867     +21     

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really slick fix, looks great!

@jstarry jstarry merged commit cffc32a into solana-labs:master Mar 16, 2022
@jstarry jstarry deleted the lut/optional-payer branch July 4, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make payer optional in ExtendLookupTable instruction
2 participants