-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intermittent validator_exit test failure #23594
Fix intermittent validator_exit test failure #23594
Conversation
add 10ms delay in the validator exit tests
67ed13d
to
bcf062c
Compare
Codecov Report
@@ Coverage Diff @@
## master #23594 +/- ##
=========================================
- Coverage 81.8% 81.6% -0.2%
=========================================
Files 581 583 +2
Lines 158312 159173 +861
=========================================
+ Hits 129518 130044 +526
- Misses 28794 29129 +335 |
Can you remove (or move to a separate commit) the code shuffle in 9f56e89? It hides the logical changes |
Yes. good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. just a curiosity to entertain
@jstarry Sure. Good point. I will create another pull request to revert this change. Thanks! |
Problem
Due to shared resources between
validator_exit
andvalidator_parallel_exit
, when they are executed in parallel by the rust test executor, these tests hangs.Summary of Changes
Use one test function to run both tests.
Fixes #