Allow sub-rent-exempt-minimum transfers to 1nc1nerator
#23382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
previously approved these changes
Mar 1, 2022
mergify bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
* Add failing test * Allow small burns to incinerator * Use check_id method (cherry picked from commit 19448ba) # Conflicts: # runtime/src/account_rent_state.rs
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Mar 1, 2022
…#23382) * Add failing test * Allow small burns to incinerator * Use check_id method
mergify bot
added a commit
that referenced
this pull request
Mar 1, 2022
…3382) (#23404) * Allow sub-rent-exempt-minimum transfers to `1nc1nerator` (#23382) * Add failing test * Allow small burns to incinerator * Use check_id method (cherry picked from commit 19448ba) # Conflicts: # runtime/src/account_rent_state.rs * Fix conflicts Co-authored-by: Tyera Eulberg <[email protected]>
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Mar 4, 2022
…#23382) * Add failing test * Allow small burns to incinerator * Use check_id method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
require_rent_exempt_accountsprevents most small transfers (< 0.00089088 SOL) to incinerator. This is because the incinerator is emptied every block, and so the first transfer is seen as creating a new account.Summary of Changes
Special case
1nc1nerator11111111111111111111111111111111to allow all transfers, regardless of size or rent-exempt status