Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-tree buildkite pipeline #233

Merged
merged 1 commit into from
May 22, 2018
Merged

Add in-tree buildkite pipeline #233

merged 1 commit into from
May 22, 2018

Conversation

mvines
Copy link
Member

@mvines mvines commented May 22, 2018

No description provided.

@mvines mvines added the work in progress This isn't quite right yet label May 22, 2018
@mvines mvines force-pushed the ci branch 6 times, most recently from 7abf8f4 to 36681ac Compare May 22, 2018 06:39
@mvines
Copy link
Member Author

mvines commented May 22, 2018

@garious or @aeyakovenko - anything that looks alarming here? I'm trying to merge the current state of the various Travis and Buildkite pipelines into one with this PR and I think it works (as well as the current system does).

Might be helpful to look at the Environment Variables at https://buildkite.com/solana-labs/solana/settings for context too.

The status checks for this PR are a mess. Once this PR lands most of them will be removed and we'll only see:

  • ci-gate nag (helpful for folks without write access so they know they need help to get their PR into buildkite CI)
  • buildkite/solana - only accessible to folks with a buildkite account
  • PUBLIC LOG: buildkite/solana - public version of ^, visible to the world

@garious
Copy link
Contributor

garious commented May 22, 2018

Looks good. You got kcov to work without docker?

@mvines
Copy link
Member Author

mvines commented May 22, 2018

You got kcov to work without docker?

It seems to get much further on Buildkite than it did on Travis at least (probably due to existing software already installed on the sagan build agent, which is a larger issue we'll need to deal with when it's time to scale CI to multiple machines).

The codecov.io setup seems to be busted though, here's the cov report from this PR and it's pretty angry: https://codecov.io/github/aeyakovenko/solana/commit/34514d65bc46028e6b3f8e66181033f49e10bd36.
Seems like this hasn't been working for quite a while, I doubt this is relate to this PR. Assuming #177 turns out, do we want codecov.io at all?

@mvines mvines mentioned this pull request May 22, 2018
4 tasks
@mvines mvines merged commit 796f4b9 into solana-labs:master May 22, 2018
@mvines mvines removed the work in progress This isn't quite right yet label May 22, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
)

Bumps [flow-bin](https://github.com/flowtype/flow-bin) from 0.130.0 to 0.131.0.
- [Release notes](https://github.com/flowtype/flow-bin/releases)
- [Commits](https://github.com/flowtype/flow-bin/commits)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
willhickey pushed a commit to willhickey/solana that referenced this pull request Mar 18, 2024
* add stats for write cache flushing

* some renames
willhickey pushed a commit that referenced this pull request Mar 20, 2024
* add stats for write cache flushing

* some renames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants