-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add comments #23275
add comments #23275
Conversation
runtime/src/in_mem_accounts_index.rs
Outdated
/// any entry at slot 'new_value.0' is replaced with 'new_value'. | ||
/// or, 'new_value' is appended to the slot list if the slot did not exist previously. | ||
/// returns true if caller should addref |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this comment pertains the new version, found here:
solana/runtime/src/in_mem_accounts_index.rs
Lines 441 to 451 in d525ef3
/// Try to update an item in the slot list the given `slot` If an item for the slot | |
/// already exists in the list, remove the older item, add it to `reclaims`, and insert | |
/// the new item. | |
/// if 'other_slot' is some, then also remove any entries in the slot list that are at 'other_slot' | |
pub fn lock_and_update_slot_list( | |
current: &AccountMapEntryInner<T>, | |
new_value: (Slot, T), | |
other_slot: Option<Slot>, | |
reclaims: &mut SlotList<T>, | |
previous_slot_entry_was_cached: bool, | |
) { |
But not this version of the fn. Dunno how you'd like to handle it for this PR though. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it
268c841
to
1358812
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Problem
Summary of Changes
Fixes #