Fix ed25519 builtin program handling (backport #23182) #23195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
added
conflicts
automerge
mvines
reviewed
Feb 16, 2022
mvines
reviewed
Feb 16, 2022
|
Sigh... I love when CI is green despite conflics |
|
😱 New commits were pushed while the automerge label was present. |
solana-grimes
removed
the
automerge
mergify
bot
added
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
|
I didn't say go, robot. Chill |
* Fix ed25519 builtin program handling * Fix tests * Add integration tests for processing transactions with ed25519 ixs * Fix another test * fix formatting (cherry picked from commit 813725d)
t-nelson
force-pushed
the
mergify/bp/v1.9/pr-23182
branch
from
8bfcb21 to
6d246ab
Compare
mergify
bot
added
the
automerge
t-nelson
reviewed
Feb 16, 2022
Comment on lines
13041
to
13065
| if bank.slot == 0 { | ||
| assert_eq!( | ||
| bank.hash().to_string(), | ||
| "DqaWg7EVKzb5Fpe92zNBtXAWqLwcedgHDicYrCBnf3QK" | ||
| "CMCWTWsU67zjmayMhSMGBTzHbW1WMCtkM5m7xk9qSnY5" | ||
| ); | ||
| } | ||
| if bank.slot == 32 { | ||
| assert_eq!( | ||
| bank.hash().to_string(), | ||
| "AYdhzhKrM74r9XuZBDGcHeFzg2DEtp1boggnEnzDjZSq" | ||
| "4kbXeShX8vMnRuuADCkxSEir1oc2PrBNbx6vPkWcDtJU" | ||
| ); | ||
| } | ||
| if bank.slot == 64 { | ||
| assert_eq!( | ||
| bank.hash().to_string(), | ||
| "EsbPVYzo1qz5reEUH5okKW4ExB6WbcidkVdW5mzpFn7C" | ||
| "CSZ8QCDF8qhqKDxafPzjNJpHcRAXmQzAb8eUi1Emt35E" | ||
| ); | ||
| } | ||
| if bank.slot == 128 { | ||
| assert_eq!( | ||
| bank.hash().to_string(), | ||
| "H3DWrQ6FqbLkFNDxbWQ62UKRbw2dbuxf3oVF2VpBk6Ga" | ||
| "Ewh1SYKy8eiSE77sEvjav33SznfWYSwa5TwqbiYWseG2" | ||
| ); | ||
| break; | ||
| } |
There was a problem hiding this comment.
This test is annoying. Maybe we should make it four tests?
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
added
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
added
automerge
|
😱 New commits were pushed while the automerge label was present. |
solana-grimes
removed
the
automerge
mergify
bot
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## v1.9 #23195 +/- ##
=========================================
- Coverage 81.2% 81.2% -0.1%
=========================================
Files 534 534
Lines 149149 149168 +19
=========================================
+ Hits 121193 121208 +15
- Misses 27956 27960 +4 |
|
This PR has been automatically locked since there has not been any activity in past 14 days after it was merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #23182 done by Mergify.
Cherry-pick of 813725d has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com