This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Cleanup: get_program_key() and get_loader_key() in TransactionContext #23191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_loader_key => get_current_loader_key.
Lichtso
added
work in progress
Lichtso
force-pushed
the
cleanup/rename_get_current_in_transaction_context
branch
from
45a3ba7 to
2123a6d
Compare
Lichtso
deleted the
cleanup/rename_get_current_in_transaction_context
branch
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Mar 4, 2022
…solana-labs#23191) * Moves TransactionContext::get_program_key() to InstructionContext::get_program_key(). * Removes TransactionContext::get_loader_key(). * Test full program and loader executable account chain in BPF loader.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
get_program_key()onTransactionContextdoes not tell the user which program accounts key is taken and also prevents the optimization of sharing the currentInstructionContexthandle with other methods.See: #23056 (comment)
Summary of Changes
get_program_key()fromTransactionContexttoInstructionContext.get_loader_key().Fixes #