Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore wait_for_nonzero_fees to TestValidatorGenesis::start_with_mint_address #23160

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

CriesofCarrots
Copy link
Contributor

Problem

solana-tokens tests are flaky. Errors look like this:

thread 'commands::tests::test_check_payer_balances_distribute_tokens_separate_payers' panicked at 'assertion failed: `(left == right)`
  left: `"0.0000025"`,
 right: `"0"`', tokens/src/commands.rs:1757:13

This is because the logic to wait for non-zero fees didn't make it into TestValidatorGenesis::start_with_mint_address here: #22738

Summary of Changes

Some DRY to bring TestValidatorGenesis::start_with_mint_address back into the fold. solana-tokens tests now pass consistently

@CriesofCarrots CriesofCarrots added the CI Pull Request is ready to enter CI label Feb 15, 2022
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #23160 (b0c13fe) into master (197f42d) will decrease coverage by 0.0%.
The diff coverage is 88.8%.

@@            Coverage Diff            @@
##           master   #23160     +/-   ##
=========================================
- Coverage    81.3%    81.3%   -0.1%     
=========================================
  Files         567      567             
  Lines      154388   154388             
=========================================
- Hits       125605   125565     -40     
- Misses      28783    28823     +40     

Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants