Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes KeyedAccounts in system_instruction_processor tests #23118

Merged

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Feb 14, 2022

Problem

Spin off from #23056, as getting rid of the KeyedAccounts in the tests is independent from replacing them by BorrowedAccount in the programs and loaders.

Summary of Changes

Removes KeyedAccount in tests of system_instruction_processor

Fixes #

@Lichtso Lichtso added the work in progress This isn't quite right yet label Feb 14, 2022
@Lichtso Lichtso force-pushed the refactor/remove_keyed_accounts_4 branch from c90c38b to 17bcf0a Compare February 14, 2022 17:46
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #23118 (17bcf0a) into master (6e5db4a) will decrease coverage by 0.0%.
The diff coverage is 85.4%.

@@            Coverage Diff            @@
##           master   #23118     +/-   ##
=========================================
- Coverage    81.3%    81.3%   -0.1%     
=========================================
  Files         564      567      +3     
  Lines      153290   154367   +1077     
=========================================
+ Hits       124726   125552    +826     
- Misses      28564    28815    +251     

@Lichtso Lichtso changed the title Removes remaining KeyedAccounts in all tests Removes KeyedAccounts in system_instruction_processor tests Feb 14, 2022
@Lichtso Lichtso removed the work in progress This isn't quite right yet label Feb 14, 2022
@Lichtso Lichtso merged commit 20bc37c into solana-labs:master Feb 14, 2022
@Lichtso Lichtso deleted the refactor/remove_keyed_accounts_4 branch February 14, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant