shrink batches when over 80% of the space is wasted #23066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeyakovenko
changed the title
aeyakovenko
force-pushed
the
shrink_dups
branch
from
3553aae to
73f7f1e
Compare
t-nelson
reviewed
Feb 11, 2022
aeyakovenko
force-pushed
the
shrink_dups
branch
from
012b784 to
2ee6541
Compare
aeyakovenko
force-pushed
the
shrink_dups
branch
from
441f674 to
afa75ad
Compare
mergify
bot
dismissed
t-nelson’s stale review
Pull request has been modified.
Codecov Report
@@ Coverage Diff @@
## master #23066 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 564 567 +3
Lines 153290 154497 +1207
=========================================
+ Hits 124726 125663 +937
- Misses 28564 28834 +270 |
mergify bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
* shrink batches when over 80% of the space is wasted (cherry picked from commit 83d31c9) # Conflicts: # core/benches/sigverify_stage.rs # core/src/sigverify_stage.rs # perf/src/sigverify.rs
mergify bot
added a commit
that referenced
this pull request
Feb 16, 2022
…#23189) * shrink batches when over 80% of the space is wasted (#23066) * shrink batches when over 80% of the space is wasted (cherry picked from commit 83d31c9) # Conflicts: # core/benches/sigverify_stage.rs # core/src/sigverify_stage.rs # perf/src/sigverify.rs * fixup! Co-authored-by: anatoly yakovenko <[email protected]>
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Mar 4, 2022
* shrink batches when over 80% of the space is wasted
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Additional empty batches in the pipeline may starve the banking stage
Summary of Changes
shrink the batches if more then 80% of the space is wasted
4096
test bench_shrink_count_packets ... bench: 2,372 ns/iter (+/- 787)
test bench_shrink_diff_big_packets ... bench: 109,311 ns/iter (+/- 613)
test bench_shrink_diff_small_packets ... bench: 109,724 ns/iter (+/- 784)
roughly 22ns per packet.
Fixes #
tag @buffalu