Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed solana-accountsdb-plugin-postgres from the monorepo as it has its own repo #22567

Conversation

lijunwangs
Copy link
Contributor

Problem

Removed solana-accountsdb-plugin-postgres from the monorepo as it has its own standalone repo
https://github.com/solana-labs/solana-accountsdb-plugin-postgres

Summary of Changes

  1. Removed accountsdb-plugin-postgres
  2. Removed it from build.

Fixes #

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #22567 (0b2a853) into master (6edeed8) will increase coverage by 0.4%.
The diff coverage is 93.8%.

@@            Coverage Diff            @@
##           master   #22567     +/-   ##
=========================================
+ Coverage    81.1%    81.5%   +0.4%     
=========================================
  Files         560      554      -6     
  Lines      151206   149636   -1570     
=========================================
- Hits       122633   122021    -612     
+ Misses      28573    27615    -958     

@lijunwangs lijunwangs requested review from carllin and jstarry January 18, 2022 22:43
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see the plugin interface reach this level of maturity! Thanks for all the hard work!

@lijunwangs lijunwangs merged commit 60850d7 into solana-labs:master Jan 19, 2022
mergify bot pushed a commit that referenced this pull request Jan 19, 2022
… its own (#22567)

Removed solana-accountsdb-plugin-postgres from the monorepo as it has its own  standalone repo now

(cherry picked from commit 60850d7)

# Conflicts:
#	Cargo.lock
#	accountsdb-plugin-postgres/Cargo.toml
#	accountsdb-plugin-postgres/src/postgres_client.rs
#	accountsdb-plugin-postgres/src/postgres_client/postgres_client_transaction.rs
lijunwangs added a commit to lijunwangs/solana that referenced this pull request Feb 16, 2022
… its own (solana-labs#22567)

Removed solana-accountsdb-plugin-postgres from the monorepo as it has its own  standalone repo now
lijunwangs added a commit that referenced this pull request Feb 16, 2022
… its own (#22567) (#23202)

Removed solana-accountsdb-plugin-postgres from the monorepo as it has its own  standalone repo now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants