Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VecDeque instead of Vec in sigverify stage (backport #22538) #22550

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 17, 2022

This is an automatic backport of pull request #22538 done by Mergify.
Cherry-pick of 4944340 has failed:

On branch mergify/bp/v1.9/pr-22538
Your branch is up to date with 'origin/v1.9'.

You are currently cherry-picking commit 49443406f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   core/benches/sigverify_stage.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/src/sigverify_stage.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot added the conflicts label Jan 17, 2022
avoid bad performance of remove(0) for a single sender

(cherry picked from commit 4944340)

# Conflicts:
#	core/src/sigverify_stage.rs
@t-nelson t-nelson force-pushed the mergify/bp/v1.9/pr-22538 branch from 51e69f5 to b4598fb Compare January 17, 2022 20:18
@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Jan 17, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Jan 17, 2022

automerge label removed due to a CI failure

@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Jan 18, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Jan 18, 2022

automerge label removed due to a CI failure

@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Jan 18, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #22550 (b4598fb) into v1.9 (96ae795) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##             v1.9   #22550     +/-   ##
=========================================
- Coverage    81.1%    81.1%   -0.1%     
=========================================
  Files         524      524             
  Lines      146485   146485             
=========================================
- Hits       118931   118910     -21     
- Misses      27554    27575     +21     

@mergify mergify bot merged commit 2b87d99 into v1.9 Jan 19, 2022
@mergify mergify bot deleted the mergify/bp/v1.9/pr-22538 branch January 19, 2022 01:46
@github-actions
Copy link
Contributor

This PR has been automatically locked since there has not been any activity in past 14 days after it was merged.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes conflicts locked PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant