This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add Bank::accounts_data_len to SetRootMetrics #22509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
accounts-data-len/datapoint
branch
from
84f5b3d to
3198a87
Compare
Codecov Report
@@ Coverage Diff @@
## master #22509 +/- ##
=========================================
- Coverage 81.1% 81.1% -0.1%
=========================================
Files 556 559 +3
Lines 150665 151002 +337
=========================================
+ Hits 122300 122497 +197
- Misses 28365 28505 +140 |
carllin
reviewed
Jan 14, 2022
| @@ -285,6 +287,7 @@ impl BankForks { | |||
| total_squash_cache_ms += squash_timing.squash_cache_ms as i64; | |||
| } | |||
| let new_tx_count = root_bank.transaction_count(); | |||
| let accounts_data_len = root_bank.load_accounts_data_len() as i64; | |||
There was a problem hiding this comment.
this is the size of the accounts data modified in a block right, not the entire size of AccountsDb? Maybe should be named accounts_data_delta_len
There was a problem hiding this comment.
It's the entire size, but only on this fork. So more than the delta, but not the entire AccountsDb.
carllin
reviewed
Jan 14, 2022
carllin
approved these changes
Jan 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Per @ryoqun's comment here, I'd like to add an alert based on the total accounts data size. But, a datapoint for it does not exist yet.
Summary of Changes
Add a datapoint for Bank::accounts_data_len to set_root()