This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Flip iter operations to keep associated address/header/packets together (backport #22245) #22256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…er (#22245) Flip iter operations to keep associated address/header/packets together Before this change, if cast_socket_addr() returned a None for any address/header pair, the subsequent zip() would misalign the address/header pair and packet. So, this change zips all three together, then does filter_map() so keep things aligned. Additionally, compute total_size inline to avoid running through packets a second time. (cherry picked from commit 20b61e2) # Conflicts: # streamer/src/recvmmsg.rs
mergify
bot
added
conflicts
automerge
|
😱 New commits were pushed while the automerge label was present. |
solana-grimes
removed
the
automerge
mergify
bot
added
automerge
|
automerge label removed due to a CI failure |
mergify
bot
added
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
behzadnouri
force-pushed
the
mergify/bp/v1.8/pr-22245
branch
from
a0d29fd to
f46f54a
Compare
mergify
bot
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## v1.8 #22256 +/- ##
=========================================
- Coverage 81.6% 81.5% -0.1%
=========================================
Files 459 459
Lines 131039 131034 -5
=========================================
- Hits 106934 106912 -22
- Misses 24105 24122 +17 |
|
This PR has been automatically locked since there has not been any activity in past 14 days after it was merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #22245 done by Mergify.
Cherry-pick of 20b61e2 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com