This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Count compute units even when transaction errors #22182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
approved these changes
Dec 30, 2021
Codecov Report
@@ Coverage Diff @@
## master #22182 +/- ##
========================================
Coverage 81.1% 81.1%
========================================
Files 523 523
Lines 146367 146505 +138
========================================
+ Hits 118704 118846 +142
+ Misses 27663 27659 -4 |
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2021
(cherry picked from commit d06e6c7) # Conflicts: # program-runtime/src/invoke_context.rs # program-runtime/src/timings.rs # program-test/src/lib.rs # programs/bpf_loader/src/syscalls.rs # runtime/src/cost_model.rs # runtime/src/message_processor.rs
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2021
(cherry picked from commit d06e6c7) # Conflicts: # program-runtime/src/invoke_context.rs # runtime/src/cost_model.rs # runtime/src/message_processor.rs
Merged
Lichtso
added a commit
that referenced
this pull request
Dec 31, 2021
* Turns compute_units_consumed of ProcessInstructionResult into a &mut parameter. * Removes second nesting level from test_process_instruction_compute_budget(). * Makes test_process_cross_program and test_native_invoke symmetric. * Unifies test_process_cross_program(), test_native_invoke() and test_process_instruction_compute_budget() into test_process_instruction().
mergify bot
added a commit
that referenced
this pull request
Dec 31, 2021
…22199) * Count compute units even when transaction errors (#22182) (cherry picked from commit d06e6c7) # Conflicts: # program-runtime/src/invoke_context.rs # runtime/src/cost_model.rs # runtime/src/message_processor.rs * Resolve conflicts Co-authored-by: carllin <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jan 1, 2022
…22198) * Resolve conflicts * Return err Co-authored-by: carllin <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Compute units and per program timings are not updated on transaction error, but simpler than
#22059
Summary of Changes
ProgramTimingsFixes #