-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web3.js: add Connection.getFeeForMessage #22128
web3.js: add Connection.getFeeForMessage #22128
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Codecov Report
@@ Coverage Diff @@
## master #22128 +/- ##
===========================================
- Coverage 81.2% 70.0% -11.3%
===========================================
Files 519 35 -484
Lines 145754 2093 -143661
Branches 0 301 +301
===========================================
- Hits 118466 1466 -117000
+ Misses 27288 523 -26765
- Partials 0 104 +104 |
@jstarry thanks again 👍 these were stupid mistakes from me 🤦♂️ |
no problem, thank you for the contribution! |
Closes #20100
Not sure that we should check the node version before making the request as Rust client do, I think it's ok if the request fails.
solana/client/src/rpc_client.rs
Lines 4799 to 4818 in bb97c8f