simplifies parse [sanitized] vote transaction #22127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22127 +/- ##
=======================================
Coverage 81.1% 81.1%
=======================================
Files 521 521
Lines 146326 146311 -15
=======================================
- Hits 118788 118787 -1
+ Misses 27538 27524 -14 |
behzadnouri
force-pushed
the
parse-vote
branch
from
c7d5e42 to
c14f30d
Compare
t-nelson
approved these changes
Dec 30, 2021
Comment on lines
+54
to
+56
| let first_instruction = message.instructions.first()?; | ||
| let program_id_index = usize::from(first_instruction.program_id_index); | ||
| let program_id = message.account_keys.get(program_id_index)?; |
There was a problem hiding this comment.
Suggested change
| let first_instruction = message.instructions.first()?; | |
| let program_id_index = usize::from(first_instruction.program_id_index); | |
| let program_id = message.account_keys.get(program_id_index)?; | |
| let program_id = message.program_id(0)?; |
There was a problem hiding this comment.
You are right. but I prefer to keep this commit precisely the same logic as the existing code.
We can introduce that change in a separate commit
| if !crate::check_id(program_id) { | ||
| return None; | ||
| } | ||
| let first_account = usize::from(*first_instruction.accounts.first()?); |
There was a problem hiding this comment.
Suggested change
| let first_account = usize::from(*first_instruction.accounts.first()?); | |
| let first_instruction = message.instructions.first()?; | |
| let first_account = usize::from(*first_instruction.accounts.first()?); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
verbose convoluted code.
Summary of Changes
simplified the code; removed ~30 lines of code.