Refactor: CPI Instruction Recording #22111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Another followup of #22102, because CPI instruction recording is currently the responsibility of the caller of
InvokeContext::process_instruction()
, clonesInstruction
s and compiles them, but neither of that is necessary.Summary of Changes
Vec<Option<Rc<RefCell<Vec<Instruction>>>>>
intoOption<Rc<RefCell<Vec<Vec<Instruction>>>>>
by unifying allInstructionRecorder
s of a transaction into one.CompiledInstruction
by recycling the account indices gathered forinstruction_accounts
.Instruction
s frominstruction_recorder.record_instruction(instruction.clone());
InvokeContext::process_instruction()
Fixes #