Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug broadcast #2208

Merged
merged 12 commits into from
Dec 20, 2018
Merged

Debug broadcast #2208

merged 12 commits into from
Dec 20, 2018

Conversation

carllin
Copy link
Contributor

@carllin carllin commented Dec 18, 2018

Problem

Broadcast stage could not process blobs fast enough during heavy load, causing leader crash due to buildup of blobs in channel.

Summary of Changes

  1. Tune RocksDb to handle this load.
  2. Bulk insert blobs to db_ledger in broadcast stage instead of one at a time.

Fixes #

@carllin carllin added work in progress This isn't quite right yet noCI Suppress CI on this Pull Request labels Dec 18, 2018
@carllin carllin requested a review from pgarg66 December 18, 2018 05:15
@carllin carllin force-pushed the DebugBroadcast branch 17 times, most recently from b1ac800 to a802ae3 Compare December 19, 2018 05:18
@carllin carllin removed the noCI Suppress CI on this Pull Request label Dec 19, 2018
@carllin carllin force-pushed the DebugBroadcast branch 4 times, most recently from 2c21115 to 30f288a Compare December 19, 2018 08:13
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #2208 into master will increase coverage by 0.12%.
The diff coverage is 99.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2208      +/-   ##
==========================================
+ Coverage   73.39%   73.52%   +0.12%     
==========================================
  Files         114      114              
  Lines       16691    16817     +126     
==========================================
+ Hits        12250    12364     +114     
- Misses       4441     4453      +12
Impacted Files Coverage Δ
src/broadcast_service.rs 95.04% <100%> (-1.78%) ⬇️
src/thin_client.rs 79.02% <100%> (+0.09%) ⬆️
src/db_window.rs 81.35% <100%> (-0.06%) ⬇️
src/db_ledger.rs 89.96% <99.48%> (+1.14%) ⬆️
src/result.rs 43.68% <0%> (-0.98%) ⬇️
src/window_service.rs 88.72% <0%> (-0.38%) ⬇️
src/rpc.rs 80.28% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a2361...30966ed. Read the comment docs.

@carllin carllin force-pushed the DebugBroadcast branch 4 times, most recently from f835451 to a4cff05 Compare December 19, 2018 08:54
@carllin carllin self-assigned this Dec 19, 2018
@carllin carllin removed the work in progress This isn't quite right yet label Dec 19, 2018
@carllin carllin removed their assignment Dec 19, 2018
@carllin carllin force-pushed the DebugBroadcast branch 2 times, most recently from d5dccab to 92c650f Compare December 19, 2018 13:09
@carllin carllin requested a review from rob-solana December 19, 2018 20:06
@carllin carllin merged commit 666af1e into solana-labs:master Dec 20, 2018
brooksprumo pushed a commit to brooksprumo/solana that referenced this pull request Jul 19, 2024
* ci: "Fix" the downstream anchor build

* Force the CI run to happen
behzadnouri pushed a commit to behzadnouri/solana that referenced this pull request Jul 19, 2024
* ci: "Fix" the downstream anchor build

* Force the CI run to happen
vovkman pushed a commit to helius-labs/solana that referenced this pull request Jul 22, 2024
* ci: "Fix" the downstream anchor build

* Force the CI run to happen

add hostname tag
ruuda pushed a commit to ChorusOne/solana that referenced this pull request Jul 24, 2024
…2208) (solana-labs#2214)

ci: "Fix" the downstream anchor build (solana-labs#2208)

* ci: "Fix" the downstream anchor build

* Force the CI run to happen

(cherry picked from commit fe652ca)

Co-authored-by: Jon C <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants