Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage program: Correct crate-type to match other native programs #2206

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

mvines
Copy link
Member

@mvines mvines commented Dec 17, 2018

These commands produced no "hihi" output from the storage program:

$ ( cd programs/native/storage/; cargo build )
$ RUST_LOG=solana=info cargo test test_replicator_startup --features="chacha"

with the following patch applied:

diff --git a/programs/native/storage/src/lib.rs b/programs/native/storage/src/lib.rs
index a449a2d..aaa8429 100644
--- a/programs/native/storage/src/lib.rs
+++ b/programs/native/storage/src/lib.rs
@@ -17,6 +17,7 @@ fn entrypoint(
     _tick_height: u64,
 ) -> Result<(), ProgramError> {
     solana_logger::setup();
+    info!("hihi");
 
     // accounts_keys[0] must be signed
     if keyed_accounts[0].signer_key().is_none() {

because the storage program was erroneously a "dylib" create instead of "cdylib" like all other native programs.

@mvines mvines changed the title Correct crate-type to match other native programs storage program: Correct crate-type to match other native programs Dec 17, 2018
@mvines mvines requested a review from sakridge December 17, 2018 23:07
@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label Dec 17, 2018
@solana-grimes solana-grimes merged commit fc56e1e into solana-labs:master Dec 17, 2018
brooksprumo pushed a commit to brooksprumo/solana that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants