Overhaul coverage setup #2202
Overhaul coverage setup #2202
Conversation
mvines
force-pushed
the
grcov
branch
4 times, most recently
from
42797f6 to
8727dc1
Compare
mvines
added
CI
mvines
force-pushed
the
grcov
branch
2 times, most recently
from
fc5854c to
256c815
Compare
|
This all works well on macOS, but blows up on Linux still. 🐧 |
|
The problem on linux appears to be that the gnco files from the different crates all end up getting written to the same |
mvines
force-pushed
the
grcov
branch
7 times, most recently
from
e56d93a to
f73c3f1
Compare
|
|
mvines
force-pushed
the
grcov
branch
5 times, most recently
from
534bed3 to
b348a13
Compare
Codecov Report
@@ Coverage Diff @@
## master #2202 +/- ##
=========================================
Coverage ? 56.56%
=========================================
Files ? 109
Lines ? 9047
Branches ? 0
=========================================
Hits ? 5117
Misses ? 3930
Partials ? 0
Continue to review full report at Codecov.
|
| echo "--- grcov" | ||
| ./grcov target/cov/debug/deps/ > target/cov/lcov_full.info | ||
|
|
||
| echo "--- filter_non_local_files_from_lcov" |
There was a problem hiding this comment.
You should be able to use the -s option of grcov to achieve the same result (ignore any file which is not in the repository)
There was a problem hiding this comment.
💔
$ ./grcov target/cov/debug/deps/ -s . > out.lcov
thread 'main' panicked at 'Only one file in the repository should end with src/packet.rs (sdk/src/packet.rs and src/packet.rs both end with that)', src/path_rewriting.rs:143:13
note: Run with `RUST_BACKTRACE=1` for a backtrace.There was a problem hiding this comment.
Awesome, thanks! If you can ping me here I'll be able to give it a test drive when ready
There was a problem hiding this comment.
Hey @marco-c, what's generally the best way to contact you? Care to join our Discord forum? https://discord.gg/k8Kq58
* Adds the feature. * Adds the feature gate logic. * Adjusts tests.
* Adds the feature. * Adds the feature gate logic. * Adjusts tests.
This PR gets coverage working again. Humans may run
./scripts/coverage.shlocally to generate a report.CI runs
./scripts/coverage.shon PRs and Pushes if any .rs files are affected. Results are attached to the buildkite job and uploaded to codecov.io.cargo-covusage has been removed, it's overly complex and unnecessary.Note that in the buildkite job for this PR, there's a message at the top telling saying "Coverage skipped as no .rs files were modified" -- we skip coverage if the PR has no .rs file changes to help with CI load. Contrast that with the demo PR at #2211.
Fixes #433