Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new net-stats require a new table #21996

Merged
merged 2 commits into from
Dec 18, 2021
Merged

Conversation

jbiseda
Copy link
Contributor

@jbiseda jbiseda commented Dec 18, 2021

Problem

net-stats table is used by net-stats.sh, addition of new net stats values are silently dropped

Summary of Changes

  • log to new "net-stats-validator" table
  • increase logging frequency to 2s

Fixes #

@jbiseda jbiseda added the v1.9 label Dec 18, 2021
Copy link
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #21996 (4c212e6) into master (97a1fa1) will increase coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21996   +/-   ##
=======================================
  Coverage    81.4%    81.4%           
=======================================
  Files         517      517           
  Lines      145463   145463           
=======================================
+ Hits       118417   118429   +12     
+ Misses      27046    27034   -12     

@carllin carllin added the v1.8 label Dec 18, 2021
@jbiseda jbiseda merged commit 3fe942a into solana-labs:master Dec 18, 2021
mergify bot pushed a commit that referenced this pull request Dec 18, 2021
(cherry picked from commit 3fe942a)

# Conflicts:
#	core/src/system_monitor_service.rs
mergify bot pushed a commit that referenced this pull request Dec 18, 2021
@jbiseda jbiseda deleted the fix_new_netstats branch December 18, 2021 08:13
mergify bot added a commit that referenced this pull request Dec 18, 2021
(cherry picked from commit 3fe942a)

Co-authored-by: Jeff Biseda <[email protected]>
mergify bot added a commit that referenced this pull request Dec 18, 2021
* new net-stats require a new table (#21996)

(cherry picked from commit 3fe942a)

# Conflicts:
#	core/src/system_monitor_service.rs

* merge

Co-authored-by: Jeff Biseda <[email protected]>
@brooksprumo brooksprumo mentioned this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants