-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up demote program write lock feature #21949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
remove-demote-program
branch
from
December 16, 2021 14:49
69a2131
to
b917fff
Compare
CriesofCarrots
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! (...until the next time we need a feature in is_writable()
;) )
mergify
bot
removed
the
automerge
Merge this Pull Request automatically once CI passes
label
Dec 16, 2021
automerge label removed due to a CI failure |
Codecov Report
@@ Coverage Diff @@
## master #21949 +/- ##
=======================================
Coverage 81.2% 81.2%
=======================================
Files 516 516
Lines 144368 144319 -49
=======================================
- Hits 117326 117310 -16
+ Misses 27042 27009 -33 |
mergify bot
pushed a commit
that referenced
this pull request
Dec 16, 2021
* Clean up demote program write lock feature * fix test (cherry picked from commit 6ff0be6) # Conflicts: # programs/bpf_loader/src/syscalls.rs # runtime/src/accounts.rs
mergify bot
added a commit
that referenced
this pull request
Dec 17, 2021
* Clean up demote program write lock feature (#21949) * Clean up demote program write lock feature * fix test (cherry picked from commit 6ff0be6) # Conflicts: # programs/bpf_loader/src/syscalls.rs # runtime/src/accounts.rs * resolve conflicts Co-authored-by: Justin Starry <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
demote_program_write_locks
feature is activated on all clusters and can be cleaned upSummary of Changes
demote_program_write_locks
behavior to enabledFixes #