Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up demote program write lock feature #21949

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Dec 16, 2021

Problem

The demote_program_write_locks feature is activated on all clusters and can be cleaned up

Summary of Changes

  • Default demote_program_write_locks behavior to enabled

Fixes #

@jstarry jstarry added the v1.9 label Dec 16, 2021
@jstarry jstarry force-pushed the remove-demote-program branch from 69a2131 to b917fff Compare December 16, 2021 14:49
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! (...until the next time we need a feature in is_writable() ;) )

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Dec 16, 2021
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Dec 16, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 16, 2021

automerge label removed due to a CI failure

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #21949 (84eac15) into master (82672b4) will increase coverage by 0.0%.
The diff coverage is 93.9%.

@@           Coverage Diff           @@
##           master   #21949   +/-   ##
=======================================
  Coverage    81.2%    81.2%           
=======================================
  Files         516      516           
  Lines      144368   144319   -49     
=======================================
- Hits       117326   117310   -16     
+ Misses      27042    27009   -33     

@jstarry jstarry merged commit 6ff0be6 into solana-labs:master Dec 16, 2021
@jstarry jstarry deleted the remove-demote-program branch December 16, 2021 22:27
mergify bot pushed a commit that referenced this pull request Dec 16, 2021
* Clean up demote program write lock feature

* fix test

(cherry picked from commit 6ff0be6)

# Conflicts:
#	programs/bpf_loader/src/syscalls.rs
#	runtime/src/accounts.rs
mergify bot added a commit that referenced this pull request Dec 17, 2021
* Clean up demote program write lock feature (#21949)

* Clean up demote program write lock feature

* fix test

(cherry picked from commit 6ff0be6)

# Conflicts:
#	programs/bpf_loader/src/syscalls.rs
#	runtime/src/accounts.rs

* resolve conflicts

Co-authored-by: Justin Starry <[email protected]>
@brooksprumo brooksprumo mentioned this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants